ansible-collections / vmware.vmware

Ansible VMWare Collection
GNU General Public License v3.0
7 stars 10 forks source link

Refactor integration tests to allow execution in real vCenter #29

Closed elsapassaro closed 4 months ago

elsapassaro commented 5 months ago
SUMMARY
ISSUE TYPE
ADDITIONAL INFORMATION

See ACA-1511

mariolenz commented 5 months ago

OT but do you think there's a chance to use this "real vCenter instance" CI for community.vmware and vmware.vmware_rest, too?

Ref: ansible-collections/community.vmware#1746

shellymiron commented 5 months ago

OT but do you think there's a chance to use this "real vCenter instance" CI for community.vmware and vmware.vmware_rest, too?

Ref: ansible-collections/community.vmware#1746

Hey Mario :) we will have a discussion about it tomorrow and we will keep this PR updated with what was decided

shellymiron commented 5 months ago

@mariolenz hey! we had a discussion about integrating the real vcenter CI within the community repo, and our thoughts is that it will be hard to control which PRs will be destructive for that env, since it serves multiple teams in redhat. regarding the vmware_rest repo, we will want to have it running on the real env, but this is a low priority for now, since it has a lot more features and we are only 2 QEs :) With that thoughts in mind, we would like to hear your opinion and if it is necessary/critical to have such job in the community

mariolenz commented 5 months ago

With that thoughts in mind, we would like to hear your opinion and if it is necessary/critical to have such job in the community

@shellymiron Probably not. But integration tests for community.vmware are still run with vCenter and ESXi 7.0 U3. It's really about time to start running those with a more current version. Latest release is 8.0 U3 and I think 7.0 will be EOL next(?) year.

That said, I'm not unhappy with Zuul. It mostly works. But I understood that you don't want to work on those integration tests because of lacking the time / knowledge / experience / whatever to do this.

I think it's both critical and necessary to run integration tests with a more current vSphere version, preferably 8.0 U3. And instead of trying to find someone who can update the Zuul integration tests accordingly or help me with yet another solution, I thought it would be the best thing if I could just re-use your solution.

shellymiron commented 5 months ago

@mariolenz I see, so the main issue is with the vsphere version yeah unfortunately we have zero knowledge with zuul, we will try to see if we can integrate our vcenter in the community without making it destructive to the env maybe with a manual trigger like /run-on-vcenter or something

shellymiron commented 5 months ago

LGTM looks good :)