search

ansible-collections / vmware.vmware

Ansible VMWare Collection
GNU General Public License v3.0
7 stars 10 forks source link

add vmware.vmware upstream CI #43

Closed shellymiron closed 4 months ago

shellymiron commented 4 months ago
SUMMARY

This is a PR for adding the action to run the integration tests on the eco vcenter installed on our baremetals. The changes are aligned with the validated content repo, and hold the same structure. The changes includes additional var sent to the the ansible-playbook command called tiny_prefix - this was added to be aligned the behaviour of the downstream CI, which runs the tests in parallel and requires this var.

COMPONENT NAME

eco-vcenter-ci.yml

NOTE

The PR tested locally and from my own fork, you can see the successful result here. We will be able to see the job runs on main only after the PR will be merged.

please review :) @anna-savina @elsapassaro

elsapassaro commented 4 months ago

The integration test for guest_info module is failing (see here) due to a known bug. Can you check why the pipeline did not fail?

shellymiron commented 4 months ago

@elsapassaro ok checkout this one I added an option to report at the end of the run if there are tests which failed and their names. the makefile will exit with value 1 and will fail the action if even 1 test failed. I will do the same for vmware_ops, I think the action there also not failing if a target failed.

maybe worth adding a comment on this test with the link to the bug, i'll add it

shellymiron commented 4 months ago

@elsapassaro I improved it - check here - wdyt?

elsapassaro commented 4 months ago

@shellymiron that's great!

elsapassaro commented 4 months ago

/lgtm