ansible-collections / vmware.vmware

Ansible VMWare Collection
GNU General Public License v3.0
7 stars 10 forks source link

Add checks in folder_template_from_vm tests #52

Closed elsapassaro closed 3 months ago

elsapassaro commented 3 months ago
SUMMARY

Extending integration tests for folder_template_from_vm module:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.23%. Comparing base (f7d6acb) to head (44b8271). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #52 +/- ## ========================================== + Coverage 27.70% 28.23% +0.53% ========================================== Files 10 14 +4 Lines 805 1066 +261 Branches 154 207 +53 ========================================== + Hits 223 301 +78 - Misses 582 765 +183 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/vmware.vmware/pull/52/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/ansible-collections/vmware.vmware/pull/52/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `28.23% <ø> (+0.53%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

prabinovRedhat commented 3 months ago

lgtm

mikemorency commented 3 months ago

@elsapassaro the test has failed twice now in the same spot but a re-run has fixed it. Im not sure if theres an issue or if its just the maintenance on the cluster messing things up? Ive tried running the build a few times and it wont fail. So i guess just the maintenance keeps interfering

elsapassaro commented 3 months ago

@mikemorency I guess so, I also ran the playbook locally and it passed