ansible-collections / vmware.vmware

Ansible VMWare Collection
GNU General Public License v3.0
7 stars 10 forks source link

Mm feature/migrate drs recommendations #74

Closed mikemorency closed 1 month ago

mikemorency commented 1 month ago
SUMMARY

When applying DRS recommendations, nothing is returned by the ApplyRecommendation method. This change adds a step to lookup the latest task associated with the VM targeted by the recommendation and monitors that task to determine if the recommendation succeeded.

ISSUE TYPE
COMPONENT NAME

cluster_drs_recommendations

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.15%. Comparing base (013afa4) to head (2ebbcf7). Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/cluster_drs_recommendations.py 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #74 +/- ## ========================================== + Coverage 26.09% 27.15% +1.05% ========================================== Files 19 22 +3 Lines 1667 1860 +193 Branches 331 354 +23 ========================================== + Hits 435 505 +70 - Misses 1232 1355 +123 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/vmware.vmware/pull/74/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/ansible-collections/vmware.vmware/pull/74/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `27.15% <0.00%> (+1.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

anna-savina commented 1 month ago

According to the actual output:

            "description": "server1 will move from host1 to host2.",

https://github.com/ansible-collections/vmware.vmware/pull/74/files#diff-885f606d18e22e32b5edc70c8b0050e053d98d58db88c5c6e939383350ac32a2R60

            "description": "server2 will move from host1 to host2.",

https://github.com/ansible-collections/vmware.vmware/pull/74/files#diff-885f606d18e22e32b5edc70c8b0050e053d98d58db88c5c6e939383350ac32a2R70