ansible-collections / vmware.vmware

Ansible VMWare Collection
GNU General Public License v3.0
7 stars 10 forks source link

fix dpm automation level option #75

Closed mikemorency closed 1 month ago

mikemorency commented 1 month ago
SUMMARY

The automation level option for dpm_cluster did not match the options that are used in the UI. This is because the API uses a different word (automated vs automatic).

This change modifies the module options to match what the user sees in the vcenter UI and docs.

ISSUE TYPE
COMPONENT NAME

cluster_dpm

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 27.26%. Comparing base (013afa4) to head (a066ca4). Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/cluster_dpm.py 33.33% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #75 +/- ## ========================================== + Coverage 26.09% 27.26% +1.16% ========================================== Files 19 22 +3 Lines 1667 1867 +200 Branches 331 357 +26 ========================================== + Hits 435 509 +74 - Misses 1232 1358 +126 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/vmware.vmware/pull/75/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/ansible-collections/vmware.vmware/pull/75/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `27.26% <33.33%> (+1.16%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikemorency commented 1 month ago

yea, i just merged this module a few days ago so it hasnt been released yet