search

ansible-collections / vmware.vmware

Ansible VMWare Collection
GNU General Public License v3.0
7 stars 10 forks source link

Drop unnecessary changelog entries #76

Closed mariolenz closed 3 weeks ago

mariolenz commented 3 weeks ago
SUMMARY

Those changelog fragments will turn up in the changelog. I wonder if this is really helpful. I mean, it's not really a change compared to the last version, is it? Those modules haven't been part of this release. This might confuse some people.

I don't have a strong opinion on this. Just merge this PR or close it if you want to keep those (future) changelog entries. Personally, I think there hasn't been a change compared to 1.5.0 so there shouldn't be any entries in the changelog, either.

ISSUE TYPE
COMPONENT NAME

cluster_drs_recommendations cluster_dpm

ADDITIONAL INFORMATION

70

71

73

74

75

cc @mikemorency

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.26%. Comparing base (013afa4) to head (4836a6b). Report is 23 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ========================================== + Coverage 26.09% 27.26% +1.16% ========================================== Files 19 22 +3 Lines 1667 1867 +200 Branches 331 357 +26 ========================================== + Hits 435 509 +74 - Misses 1232 1358 +126 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/vmware.vmware/pull/76/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/ansible-collections/vmware.vmware/pull/76/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `27.26% <ø> (+1.16%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikemorency commented 3 weeks ago

One of the actions requires a changelog file every PR. We should probably allow people to skip that with a label or something

mariolenz commented 3 weeks ago

One of the actions requires a changelog file every PR. We should probably allow people to skip that with a label or something

I'm not sure if this is really helpful. I think whoever reviews a PR should decide if it's worth a changelog entry or not. On the other hand, I guess that in 80, 90 or even more % of the cases a changelog fragment is necessary. So maybe it helps if the CI checks that one exists.

This is a very special case IMHO. trivial might have been an alternative. This makes your CI happy but doesn't turn up in the changelog AFAIK.

mariolenz commented 3 weeks ago

Thanks for reviewing @mikemorency and @bardielle!