ansible-collections / vmware.vmware

Ansible VMWare Collection
GNU General Public License v3.0
7 stars 10 forks source link

migrate cluster info module from community #80

Open mikemorency opened 1 week ago

mikemorency commented 1 week ago
SUMMARY

This migrates the vmware_cluster_info module from the community.vmware collection to this collection. The inputs are mostly the same. There is one input that was renamed to match the guest_info module (gather_tags). The outputs are mostly the same. However, there are some changes worth noting:

ISSUE TYPE
COMPONENT NAME

cluster_info

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 24.46043% with 105 lines in your changes missing coverage. Please review.

Project coverage is 27.03%. Comparing base (013afa4) to head (5313bde). Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
plugins/module_utils/_vmware_facts.py 13.92% 68 Missing :warning:
plugins/modules/cluster_info.py 38.59% 35 Missing :warning:
plugins/module_utils/_vmware_rest_client.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #80 +/- ## ========================================== + Coverage 26.09% 27.03% +0.93% ========================================== Files 19 23 +4 Lines 1667 2005 +338 Branches 331 374 +43 ========================================== + Hits 435 542 +107 - Misses 1232 1463 +231 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/vmware.vmware/pull/80/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/ansible-collections/vmware.vmware/pull/80/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `27.03% <24.46%> (+0.93%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.