ansible-collections / vmware.vmware

Ansible VMWare Collection

GNU General Public License v3.0

7 stars 10 forks source link

Fix CI sanity tests #9

Closed mariolenz closed 7 months ago

mariolenz commented 7 months ago

SUMMARY

The unit tests look better now, but there are still problems with the sanity tests. It looks like the doc fragment is missing.

This won't fix the sanity tests, I think we'll see some new issues once this is merged. But one thing at a time.

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request

COMPONENT NAME

cluster cluster_drs cluster_ha vm_vm_drs_rule plugins/module_utils/vmware.py tests/integration/targets/cluster/playbook.yml tests/unit/plugins/modules/common/utils.py

ADDITIONAL INFORMATION

5

mariolenz commented 7 months ago

There are now some unused-import and undocumented-parameter errors, but I don't understand why I don't see them in community.vmware :shrug:

I'll have a closer look at them once this is merged.

mariolenz commented 7 months ago

At least the sanity tests succeed now. No idea what's wrong with the other tests, there aren't similar ones in community.vmware. So I don't know if I can help there.

But the sanity tests look OK now :tada:

mariolenz commented 7 months ago

@bardielle @machacekondra So, what should we do with this PR? Merge it so at least the sanity tests succeed? Or do you have any other plans?

machacekondra commented 7 months ago

@bardielle @machacekondra So, what should we do with this PR? Merge it so at least the sanity tests succeed? Or do you have any other plans?

Thank you @mariolenz . I will take a look at the rest of the failures.