Closed alinabuzachis closed 10 months ago
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/e364d9d47a654d3b8c8502354396a98e
:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 35s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 13s :heavy_check_mark: tox-cloud-refresh-examples-vmware SUCCESS in 11m 01s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 12s
@mariolenz @jillr Integration tests seem passing in the CI with the new new API version. I used this one https://github.com/ansible-collections/vmware.vmware_rest/pull/449
Cool!
There are a lot of linter errors, though. I think we can fix those Imports are incorrectly sorted and/or formatted
by changing the order here:
I'll create a PR for that and then maybe we can try again.
@alinabuzachis Did the three new mappings I've suggested fix generating the modules? If yes, I would add them to my PR.
@alinabuzachis @jillr ansible-community/ansible.content_builder#74
Once this one and ansible-community/ansible.content_builder#73 are merged, I think we should give it another try 😃
@alinabuzachis Did the three new mappings I've suggested fix generating the modules? If yes, I would add them to my PR.
Yes, they fixed. Can you please add them here https://github.com/ansible-community/ansible.content_builder/pull/73?
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/115787c208d846bc930332567fd1d602
:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 16m 05s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 03s :heavy_check_mark: tox-cloud-refresh-examples-vmware SUCCESS in 10m 36s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 13s
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/631a86a7e685409490be1e08fc010d34
:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 42s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 09s :heavy_check_mark: tox-cloud-refresh-examples-vmware SUCCESS in 10m 54s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 42s
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
1939c7d
) 35.67% compared to head (32e08ed
) 34.15%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@alinabuzachis There are still a lot of failing CI jobs, and I think we should fix them before merging. I'm sure ansible-community/ansible.content_builder#73 and ansible-community/ansible.content_builder#74 would, but we need someone to merge them. I've tested in #452 and this looked OK to me. Of course, you can patch my changes into your local content_builder but having them upstream would be better.
One other thing: I've removed all module documentation from the community.vmware repository. It just felt like a waste of resources to generate them and drag them around. The stuff is available in the Ansible community documentation, anyway... and your module documentation is, too. Maybe you should consider this also. Just an idea ;-)
Since this doesn't concern the published collection, I don't think this would need a new major release and you could do it anytime. But preparing one, anyway, seems like a good moment to do it. That is, if you want to do it... as I've said: Just an idea.
Fixed linters and sanity errors! I tested too and those patches look good to me! Thanks!
We have the same way of handing docs in other collections too (see amazon.aws https://docs.ansible.com/ansible/latest/collections/amazon/aws/index.html). I'll try to add the Github workflow in another PR and eventually merged it after the 3.0.0 release. We can always do minor releases.
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/3e5067205469419b9f989fd02a3458e2
:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 51s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 23s :heavy_check_mark: tox-cloud-refresh-examples-vmware SUCCESS in 10m 51s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 35s
Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/6e617dfed896445caef4425f57119853
:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 56s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 12s :heavy_check_mark: tox-cloud-refresh-examples-vmware SUCCESS in 11m 01s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 36s
:partying_face:
SUMMARY
Prep 3.0.0 using vSphere API version 7.0.3
Release date is Monday November 27.
ISSUE TYPE
- New Module Pull Request ##### COMPONENT NAMEseveral