ansible-collections / vmware.vmware_rest

Ansible Collection for VMWare (REST modules)
GNU General Public License v3.0
126 stars 56 forks source link

Fix options parsing to use vcenter_validate_certs false value #462

Closed hakbailey closed 5 months ago

hakbailey commented 5 months ago
SUMMARY

Fixes the credentials options parsing to use vcenter_validate_certs=false if provided. It was previously defaulting to the env variable for any falsy value of vcenter_validate_certs, which meant both None (option not provided) and False (passed by the user) values were ignored.

Fixes #425

ISSUE TYPE
COMPONENT NAME

plugin_utils.lookup

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (143083f) 34.15% compared to head (dbaf40a) 34.18%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #462 +/- ## ========================================== + Coverage 34.15% 34.18% +0.02% ========================================== Files 143 143 Lines 11055 11040 -15 Branches 2294 2291 -3 ========================================== - Hits 3776 3774 -2 + Misses 7279 7266 -13 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/vmware.vmware_rest/pull/462/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Ξ” | | |---|---|---| | [sanity](https://app.codecov.io/gh/ansible-collections/vmware.vmware_rest/pull/462/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `34.18% <ΓΈ> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/c2f8cdaefa4041c590498fcc9c11901b

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 13m 19s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 21s :heavy_check_mark: tox-cloud-refresh-examples-vmware SUCCESS in 10m 48s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 02s

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/02c72ab7b06742dda8fc4e2e1b2911fa

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 13m 29s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 15s :heavy_check_mark: tox-cloud-refresh-examples-vmware SUCCESS in 10m 47s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 53s

mariolenz commented 5 months ago

Does anyone know why addind the mergeit label didn't merge the PR? I thought it would run ansible/gate and merge if this succeeds, but it's still "Expected β€” Waiting for status to be reported".

alinabuzachis commented 5 months ago

regate

alinabuzachis commented 5 months ago

@mariolenz If it won't merge, we should probably try to dismiss the pending reviewer and then regate.

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/b7456a1746b9461aacbf26d12b9627ac

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 09s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 58s :heavy_check_mark: tox-cloud-refresh-examples-vmware SUCCESS in 10m 40s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 14s

patchback[bot] commented 3 months ago

Backport to stable-3: πŸ’š backport PR created

βœ… Backport PR branch: patchback/backports/stable-3/f5d7fd256418e900016d4b606a33beb98fab552b/pr-462

Backported as https://github.com/ansible-collections/vmware.vmware_rest/pull/487

πŸ€– @patchback I'm built with octomachinery and my source is open β€” https://github.com/sanitizers/patchback-github-app.