ansible-collections / vmware.vmware_rest

Ansible Collection for VMWare (REST modules)
https://ansible-collections.github.io/vmware.vmware_rest/
GNU General Public License v3.0
132 stars 64 forks source link

Release 4.0.0 #511

Closed mikemorency closed 3 months ago

mikemorency commented 3 months ago
SUMMARY

This is release 4.0.0, which includes new openapi specs for vsphere 8.0.2. It also includes two new modules:

In addition to the updated modules, the following is included in the release:

  1. remove support for ansible-core 2.14
  2. Up to date instructions and playbooks for generating module content in this repo. This information has been added to development.md
  3. various doc updates for lookup plugins and the README
ADDITIONAL INFORMATION

Related: https://github.com/ansible-community/ansible.content_builder/pull/89

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/8163ef7467b34a5d896fab115a8a445e

:x: ansible-test-cloud-integration-vmware-rest FAILURE in 11m 38s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 01s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 35s

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/31e028386c894dc28148a23d6cacb71b

:x: ansible-test-cloud-integration-vmware-rest FAILURE in 13m 34s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 53s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 12s

mariolenz commented 3 months ago

@mikemorency Maybe we need to define the vmware.vmware collection as a test dependency to make the docs test work?

mikemorency commented 3 months ago

do we want to do that though? its not an actual dependency, so i hesitated adding it

mariolenz commented 3 months ago

do we want to do that though? its not an actual dependency

No, we don't want to make this a dependency for the collection if it isn't. I'm looking for a way to make it a dependency just for the docs test. Maybe using extra-collections would help? :thinking:

I don't know if this works if we do it in this PR, though. Maybe we need to change the CI workflow in a separate PR.

mikemorency commented 3 months ago

i tried adding the extra-collections. I can see the collection is installed, but it doesnt seem to have an affect for some reason.

Also theres an ayncio deprecation thats causing the python3.12 tests to fail. Im not sure what the best way to move forward with that is

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/8de5d6c78a9046f098c9e06befded0cb

:x: ansible-test-cloud-integration-vmware-rest FAILURE in 12m 01s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 42s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 13s

mariolenz commented 3 months ago

This is weird, I don't see any docs checks ATM and I don't understand why...

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/2a978893c09d4042bddc80829b0f11f8

:x: ansible-test-cloud-integration-vmware-rest FAILURE in 12m 14s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 37s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 47s

mariolenz commented 3 months ago

@mikemorency How did you generate config/api_specifications/8.0.2? I think you should document this in this PR.

Not to put too fine a point on this, but I think there's a general problem here. You people are doing a lot of PRs without really explaining. For example #494 which really sucks.

I always try to add as much information as possible in order to help people understand what I'm trying to do. See #449 for an example.

It would be really great if you would add a little bit more information to your PRs.

cc @alinabuzachis @bardielle @jillr

mikemorency commented 3 months ago

I was using this draft PR to test CI results, so I didnt fill out the PR description. Ill do that now!

The steps I took to generate this release have been documented in development.md included in the PR. For the api spec:

1. Get the OpenAPI spec from VCenter
    a. Clone https://github.com/vmware/vmware-openapi-generator
    b. Run `python vmsgen.py -vc 'your_vcenter_ip_or_hostname' -o gen_out --insecure --oas 2` from within the checked out repo
    c. validate the directory `gen_out` has the spec files. Note `--oas 2` generates version 2 spec files. Version 3 seems bugged https://github.com/vmware/vmware-openapi-generator/issues/73

This experience has certainly made me feel that a general lack of documentation and "magic behind the scenes" makes contribution to this repo challenging.

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/1b31096e0648492c95583c090e371307

:x: ansible-test-cloud-integration-vmware-rest FAILURE in 13m 17s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 53s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 27s

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/30c7777c6ec14fb5a3f2089653866fc9

:x: ansible-test-cloud-integration-vmware-rest FAILURE in 14m 24s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 42s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 13s

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/9c84e92e6c0d4daa9d27f8be9f252671

:warning: ansible-test-cloud-integration-vmware-rest SKIPPED Skipped due to failed job build-ansible-collection :x: build-ansible-collection FAILURE in 4m 47s :warning: ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/48332ebd34324e53bf3261fd2a539ae2

:x: ansible-test-cloud-integration-vmware-rest FAILURE in 13m 29s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 55s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 49s

mariolenz commented 3 months ago

This experience has certainly made me feel that a general lack of documentation and "magic behind the scenes" makes contribution to this repo challenging.

Yes, that's exactly why I think it helps to be more explicit when creating a PR and tell people what has been done. This helps people to understand what has been done, even if the documentation is outdated, missing important steps or even plain wrong.

Additionally, I like to document exactly what I did in a PR even for myself. It helps me if I want to do something similar again. I don't have to remember, I can look at my PRs and start from there ;-)

mariolenz commented 3 months ago

@mikemorency Cool! It looks like you were able to fix the docs CI job. Thanks, really great!

I'm not sure why the ansible-test-cloud-integration-vmware-rest Zuul job fails, though. I'll try to investigate.

softwarefactory-project-zuul[bot] commented 3 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/afd2a5c0833f47c6b831c9d6cdf0d164

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 13m 55s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 49s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 12s

softwarefactory-project-zuul[bot] commented 3 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/fb44822d02fe43038f686b84092f5c0e

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 32s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 41s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 15s

softwarefactory-project-zuul[bot] commented 3 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/6c447f75bed34618ae33b472f5d5af37

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 19s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 49s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 04s

mariolenz commented 3 months ago

Looks like we have three approvals and no open change requests. I'll add the mergeit label.

@bardielle @machacekondra Please feel free to open an undo commit if you think I've been wrong merging this PR.

@mikemorency Maybe you should wait one or two days before you add the 4.0.0 tag that triggers the release. Just in case someone changes their mind.

softwarefactory-project-zuul[bot] commented 3 months ago

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/48f9f16b8a3c464b9244094265f741f8

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 13m 26s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 42s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 30s

softwarefactory-project-zuul[bot] commented 3 months ago

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

mariolenz commented 3 months ago

I've merged this manually, but while the CI looked OK the Publish Collection Docs / Build Ansible Docs (push) failed. Any ideas why?

Any ideas why?

mikemorency commented 3 months ago

the push workflow here is missing this attribute