search

ansible-collections / vmware.vmware_rest

Ansible Collection for VMWare (REST modules)
https://ansible-collections.github.io/vmware.vmware_rest/
GNU General Public License v3.0
132 stars 64 forks source link

Fix Build Ansible Docs workflow #518

Closed mariolenz closed 3 months ago

mariolenz commented 3 months ago
SUMMARY

Trying to fix the Build Ansible Docs CI workflow which fails ATM.

ISSUE TYPE
COMPONENT NAME

.github/workflows/docs-push.yml

ADDITIONAL INFORMATION

This and the following comment.

softwarefactory-project-zuul[bot] commented 3 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/a350b208b0bc48269bff1c6e8816bc99

:heavy_check_mark: build-ansible-collection SUCCESS in 8m 01s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 03s

softwarefactory-project-zuul[bot] commented 3 months ago

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/8bcac0bccc264990870696a3af8bcc62

:heavy_check_mark: build-ansible-collection SUCCESS in 7m 56s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 25s

softwarefactory-project-zuul[bot] commented 3 months ago

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

mariolenz commented 3 months ago

This fixed the original error, but now there's a new one.

@mikemorency @alinabuzachis This workflow is quite new, it looks like you've introduced it only 3 weeks ago. Do we really need (or at least want) this? In that case, it would be great if you could make it succeed.

If not, should we simply drop it?

mikemorency commented 3 months ago

I got the action to pass, but the github pages link just leads to a 404. I dont really see any other collection repos with github pages or built RST files. Is this some legacy way of documenting the collections or just a one off quirk?

mariolenz commented 3 months ago

I have no idea :shrug:

You've introduced this in #505 and @alinabuzachis approved. Where did you get this workflow from, and why did you add it?

For community.vmware I've dropped the docs some time ago and simply rely on it being part of the Ansible Community Package and the documentation showing up on docs.ansible.com.

Which is also the case for vmware.vmware_rest.

So if neither you nor @alinabuzachis can give a good reason to have this workflow, I repeat my suggestion to drop it ;-)