ansible-collections / vmware.vmware_rest

Ansible Collection for VMWare (REST modules)
https://ansible-collections.github.io/vmware.vmware_rest/
GNU General Public License v3.0
132 stars 64 forks source link

adding better documentation for the customization module #534

Closed mikemorency closed 1 month ago

mikemorency commented 2 months ago
SUMMARY

Updates the examples in the vm customization module to be more detailed and cover both the linux and cloud-init configuration schemes.

Fixes https://github.com/ansible-collections/vmware.vmware_rest/issues/472 https://github.com/ansible-collections/vmware.vmware_rest/issues/527

ISSUE TYPE
COMPONENT NAME

vcenter_vm_guest_customization

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.04%. Comparing base (a9a257f) to head (0cb44d6). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #534 +/- ## ========================================== + Coverage 36.58% 37.04% +0.46% ========================================== Files 145 145 Lines 11549 11388 -161 Branches 2301 2258 -43 ========================================== - Hits 4225 4219 -6 + Misses 7324 7169 -155 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/vmware.vmware_rest/pull/534/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/ansible-collections/vmware.vmware_rest/pull/534/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `37.04% <ø> (+0.46%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

softwarefactory-project-zuul[bot] commented 2 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/eacd44719e764767a325757fd222d2d8

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 13m 22s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 47s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 26s

softwarefactory-project-zuul[bot] commented 1 month ago

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/836363a2a9db45399e8602a0e69cffc6

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 10m 59s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 51s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 6m 32s

sean-freeman commented 1 month ago

@mikemorency @bardielle This PR takes my provided code in #471 for cloud-init, but does not fix #471 and therefore is documenting a procedure that cannot possibly work for any end-user. It should be removed from the Ansible Collection documentation until the procedure is confirmed working.