ansible-collections / vmware.vmware_rest

Ansible Collection for VMWare (REST modules)
https://ansible-collections.github.io/vmware.vmware_rest/
GNU General Public License v3.0
132 stars 64 forks source link

fix nonsensical path results in lookup plugin #550

Closed mikemorency closed 6 days ago

mikemorency commented 1 week ago
SUMMARY

If someone specifies a path to an object (like a cluster) that cannot contain the lookup object, the plugin ignores the cluster name and just uses the datacenter as a filter.

Ideally, I think we would throw an error telling the user that they are searching for a path the doesnt make sense. But the old plugin output is just an empty string, so I am keeping that output.

ISSUE TYPE
COMPONENT NAME

lookup plugins

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 13.51351% with 32 lines in your changes missing coverage. Please review.

Project coverage is 37.04%. Comparing base (81953ff) to head (378c167). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
plugins/plugin_utils/lookup.py 13.51% 32 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #550 +/- ## ========================================== - Coverage 37.04% 37.04% -0.01% ========================================== Files 145 145 Lines 11388 11400 +12 Branches 2258 2262 +4 ========================================== + Hits 4219 4223 +4 - Misses 7169 7177 +8 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/vmware.vmware_rest/pull/550/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/ansible-collections/vmware.vmware_rest/pull/550/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `37.04% <13.51%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

softwarefactory-project-zuul[bot] commented 1 week ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/b754eb1565cd4d3f99a7f9fe71e647d1

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 09s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 15s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 22s

softwarefactory-project-zuul[bot] commented 6 days ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/b2ae0fc321d54b9f83d258a9057a974d

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 11m 12s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 23s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 12s

softwarefactory-project-zuul[bot] commented 6 days ago

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/e030713429aa4f98bbc634492825160c

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 10m 05s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 23s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 42s