Closed mikemorency closed 6 days ago
Attention: Patch coverage is 13.51351%
with 32 lines
in your changes missing coverage. Please review.
Project coverage is 37.04%. Comparing base (
81953ff
) to head (378c167
). Report is 7 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
plugins/plugin_utils/lookup.py | 13.51% | 32 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/b754eb1565cd4d3f99a7f9fe71e647d1
:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 09s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 15s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 22s
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/b2ae0fc321d54b9f83d258a9057a974d
:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 11m 12s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 23s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 12s
Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/e030713429aa4f98bbc634492825160c
:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 10m 05s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 23s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 42s
SUMMARY
If someone specifies a path to an object (like a cluster) that cannot contain the lookup object, the plugin ignores the cluster name and just uses the datacenter as a filter.
Ideally, I think we would throw an error telling the user that they are searching for a path the doesnt make sense. But the old plugin output is just an empty string, so I am keeping that output.
ISSUE TYPE
COMPONENT NAME
lookup plugins