search

ansible-collections / vmware.vmware_rest

Ansible Collection for VMWare (REST modules)
https://ansible-collections.github.io/vmware.vmware_rest/
GNU General Public License v3.0
132 stars 64 forks source link

deprecate content_library_item_info due to module generation issues #551

Open mikemorency opened 2 days ago

mikemorency commented 2 days ago
SUMMARY

Fixes issue https://github.com/ansible-collections/vmware.vmware_rest/issues/540

Deprecate module content_library_item_info in favor of vmware.vmware.content_library_item_info. The module in this collection was not generated correctly, leading to it failing in some use cases. We cannot easily fix this since the issue is in the openapi spec provided by vmware.

ISSUE TYPE
COMPONENT NAME

content_library_item_info

softwarefactory-project-zuul[bot] commented 2 days ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/ca2f39b34c8441cbb9c3ac54b75e557a

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 13m 19s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 31s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 51s

billy-stellar commented 2 days ago

@mikemorency does this mean vmware.vmware will soon have a .content_library_item_info module? I don't see that documented today, nor in the source code.

mikemorency commented 2 days ago

Hi @billy-stellar ,

Yes, we will be adding a content_library_item_info module with the next minor release. The PR to add the module is open in the vmware.vmware repo. Both vmware.vmware and vmware.vmware_rest have minor releases planned in the next ~2 weeks

mariolenz commented 2 days ago

@mikemorency Some of the tests fail. I think I had a similar problem in community.vmware and solved it like this:

https://github.com/ansible-collections/community.vmware/blob/394a5a6bc05288af8054e8d1e20cba94a2957b7d/.github/workflows/extra-docs-linting.yml#L34-L37

I'm not sure if you would also have to install vmware.vmware somewhere explicitly, but I think you should wait until the module really is part of vmware.vmware to make the CI happy.

Both vmware.vmware and vmware.vmware_rest have minor releases planned in the next ~2 weeks

There will be new releases of the Ansible Community Package December 3rd, and the next one will be end of January. It would be great if you could do those releases in time so we can include them! Of course, this will only work if we're talking about minor releases here ;-)

BTW those will be the last 9.x and 10.x releases. From then on, it's ansible 11 or nothing.