Closed mikemorency closed 1 day ago
Attention: Patch coverage is 0%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 37.05%. Comparing base (
81953ff
) to head (d34300b
). Report is 8 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
plugins/plugin_utils/lookup.py | 0.00% | 7 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/0106d1389b8b4828be3b906ad99872fb
:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 10s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 36s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 6m 18s
Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/8be958fd5fd543d58ba8efbcdd0f7d01
:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 15s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 37s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 08s
SUMMARY
After refactoring one of the methods, lookup results broke. This was partially due to missing async keywords and improper dictionary cloning when creating a temporary set of search filters
This issue also made it clear that the filters do not need (nor should be) reset each time we search for an object. The method that performed that reset has been removed
ISSUE TYPE
COMPONENT NAME
all lookup plugins