ansible-collections / vmware.vmware_rest

Ansible Collection for VMWare (REST modules)
https://ansible-collections.github.io/vmware.vmware_rest/
GNU General Public License v3.0
132 stars 64 forks source link

Bugfix/lookup plugin regression #552

Closed mikemorency closed 1 day ago

mikemorency commented 2 days ago
SUMMARY

After refactoring one of the methods, lookup results broke. This was partially due to missing async keywords and improper dictionary cloning when creating a temporary set of search filters

This issue also made it clear that the filters do not need (nor should be) reset each time we search for an object. The method that performed that reset has been removed

ISSUE TYPE
COMPONENT NAME

all lookup plugins

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 37.05%. Comparing base (81953ff) to head (d34300b). Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
plugins/plugin_utils/lookup.py 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #552 +/- ## ======================================= Coverage 37.04% 37.05% ======================================= Files 145 145 Lines 11388 11395 +7 Branches 2258 2261 +3 ======================================= + Hits 4219 4222 +3 - Misses 7169 7173 +4 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/vmware.vmware_rest/pull/552/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/ansible-collections/vmware.vmware_rest/pull/552/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `37.05% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

softwarefactory-project-zuul[bot] commented 2 days ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/0106d1389b8b4828be3b906ad99872fb

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 10s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 36s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 6m 18s

softwarefactory-project-zuul[bot] commented 1 day ago

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/8be958fd5fd543d58ba8efbcdd0f7d01

:heavy_check_mark: ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 15s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 37s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 08s