Avoid starting the service twice

ansible-community / ansible-nomad

:watch: Ansible role for Nomad

https://galaxy.ansible.com/brianshumate/nomad

BSD 2-Clause "Simplified" License

294 stars 163 forks source link

Avoid starting the service twice #123

Closed ygalblum closed 3 years ago

ygalblum commented 3 years ago

Only enable service in the main task and let the handler start it

The solution is for systemd only

Fixes #118

lanefu commented 3 years ago

@ygalblum I feel like the result from this task should be registered.. and the other.2 steps in the block should only execute if the template is changed/updated.

what are your thoughts?

PS feel free to @ me in your PRs as well.. I have yet to figure out how to get notifications from this repo when PRs are opened.

ygalblum commented 3 years ago

@lanefu I wanted to limit my change so I did not add this skip. But, you are right. Please see revised change

lanefu commented 3 years ago

awesome.. thank you @ygalblum