ansible-community / ansible-nomad

:watch: Ansible role for Nomad
https://galaxy.ansible.com/brianshumate/nomad
BSD 2-Clause "Simplified" License
298 stars 166 forks source link

Linting issue commit missing in latest release #71

Closed DarrenTsung closed 4 years ago

DarrenTsung commented 4 years ago

Hi, when I install this role via ansible-galaxy, the source appears to missing the latest commit which fixes a linting issue. Unfortunately this causes ansible to fail with a syntax error:

- name: Add Nomad user to docker group
  when: "{{ nomad_user }}" != "root"
                           ^ here

If you run: ansible-galaxy role info brianshumate.nomad, it appears like the commit is included:

Role: brianshumate.nomad
    description: Nomad cluster role
    active: True
    commit: 6946dfed63663709ab87dbd269bf35ce2ca1f1bc
    commit_message: Fix linting issue in Docker tasks
    commit_url: https://api.github.com/repos/brianshumate/ansible-nomad/git/commits/6946dfed63663709ab87dbd269bf35ce2ca1f1bc
    company: Brian Shumate
    created: 2017-02-23T23:14:07.668561Z
    dependencies: []
    download_count: 4509
    forks_count: 58
    galaxy_info:
        author: Brian Shumate
        company: Brian Shumate
        galaxy_tags: ['clustering', 'monitoring', 'networking', 'scheduling', 'system']
        license: BSD
        min_ansible_version: 2.5
        platforms: [{'name': 'Archlinux', 'versions': ['all']}, {'name': 'EL', 'versions': [6, 7]}, {'name': 'Ubuntu', 'versions': ['vivid', 'xenial']}, {'name': 'Debian', 'versions': ['jessie']}, {'name': 'Windows', 'versions': ['2012R2']}]
    github_branch: master
    github_repo: ansible-nomad
    github_user: brianshumate
    id: 15834
    imported: 2019-12-17T16:44:28.033546-05:00
    install_date: Sun Jan  5 19:19:35 2020
    installed_version: v1.9.3
    is_valid: True
    issue_tracker_url: https://github.com/brianshumate/ansible-nomad/issues
    license: BSD
    min_ansible_version: 2.5
    modified: 2019-12-17T21:44:28.045301Z
    open_issues_count: 8
    path: (u'/root/.ansible/roles', u'/usr/share/ansible/roles', u'/etc/ansible/roles')
    role_type: ANS
    stargazers_count: 103
    travis_status_url: https://travis-ci.org/brianshumate/ansible-nomad.svg?branch=master

However, I can verify the incorrect code is included in the release package at: https://github.com/brianshumate/ansible-nomad/archive/v1.9.3.zip.

brianshumate commented 4 years ago

Hi, sorry about that; there is a 1.9.4 release available now which definitely contains that fix.

DarrenTsung commented 4 years ago

Thank you!