search

ansible-community / ansible-nomad

:watch: Ansible role for Nomad
https://galaxy.ansible.com/brianshumate/nomad
BSD 2-Clause "Simplified" License
298 stars 166 forks source link

add enable_tls variable #87

Closed imcitius closed 4 years ago

imcitius commented 4 years ago

More convenient way to add tls configuration block.

rndmh3ro commented 4 years ago

FYI: this is a breaking change.

If you previously defined only the tls certificates and now roll out nomad with this new configuration, TLS will be disabled.

lanefu commented 4 years ago

Crap

Should we rollback?

imcitius commented 4 years ago

I think initial role design wasn't good in this. We can roll-back for now of course, and decide how to introduce this kind of changes in future?

imcitius commented 4 years ago

The purpose of this change was to separate operations of copy certificates to nomad config, and enabling TLS. In my case certificates is put in place by another role, and copying files is not needed. I'm pretty sure that this logic is more universal.

rndmh3ro commented 4 years ago

If this role uses semantic versioning, then everything is fine, since there's no new version released yet.

I'm in favor of this change, no questions here!

So I don't think anything should be done here.