search

ansible-community / antsibull-build

Tooling for building various things related to ansible
GNU General Public License v3.0
60 stars 31 forks source link

setup.py: avoid using recursive globs for package_data #520

Closed felixfontein closed 1 year ago

felixfontein commented 1 year ago

These are only supported since setuptools 62.3.0 (https://github.com/pypa/setuptools/blob/main/CHANGES.rst#v6230) (see https://github.com/pypa/setuptools/issues/1806 for details).

felixfontein commented 1 year ago

I haven't been able to test this yet, since every single time I try to build Ansible, downloading ansible-core (for the combined changelog) ends up with a TimeoutError (most likely due to my internet connection at the moment). I'll probably have to rip some code out to see whether this works...

felixfontein commented 1 year ago

I've now been able to test this (with some out-commented code), and it seems to work well - even better than before, now ansible_collections-new/cyberark/conjur/roles/conjur_host_identity/tests/.pytest_cache/ is included as it should (except that this directory shouldn't have been there in the first place, but that's another story). The downside is that setup.py now has almost 3300 lines...

felixfontein commented 1 year ago

@gotmax23 thanks for reviewing, merging, and releasing :)