ansible-community / antsibull-build

Tooling for building various things related to ansible
GNU General Public License v3.0
60 stars 31 forks source link

Move ansible setuptools configuration into setup.cfg #530

Closed gotmax23 closed 1 year ago

gotmax23 commented 1 year ago

Fixes: https://github.com/ansible-community/antsibull/issues/504

gotmax23 commented 1 year ago

The contents of the wheels for 7.5.0 and 8.0.0a3 are the same before and after this change.

felixfontein commented 1 year ago

I think this is too late for the Ansible 8 release cycle, and definitely too late for the Ansible 7 release cycle, and should thus only apply to Ansible 9+.

gotmax23 commented 1 year ago

Fair enough. I'll add back that code for those versions.

gotmax23 commented 1 year ago

TODO: add a changelog entry

gotmax23 commented 1 year ago

I'm not sure what's causing:

ERROR: found collection dependency errors!
ERROR: dellemc.enterprise_sonic version_conflict: ansible.netcommon-5.1.1 but needs >=2.0.0,<5.0.0

-- https://github.com/ansible-community/antsibull/actions/runs/5040720589/jobs/9039753648?pr=530#step:12:14

The build-dumb-pypi job seems to be building for 7.99.0. Ansible 7 has

ansible.netcommon: >=4.1.0,<5.0.0

so I'm not sure how ansible.netcommon-5.1.1 is getting in there...

felixfontein commented 1 year ago

That CI workflow is generating a new .build file for every run ("Generate the list of compatible versions" step).

gotmax23 commented 1 year ago

I force pushed to update the changelog entry. This should be ready for review now.

gotmax23 commented 1 year ago

That CI workflow is generating a new .build file for every run ("Generate the list of compatible versions" step).

Ah, I didn't read that workflow closely enough. Thanks! I guess we'll need to fix that separately.

gotmax23 commented 1 year ago

Squashed fixup commit

gotmax23 commented 1 year ago

Thanks for reviewing this @felixfontein. I plan to let this sit for a couple days and then cut a new release. We have a good amount of unreleased changes.

felixfontein commented 1 year ago

Thanks for working on this! Sounds good to me.