search

ansible-community / antsibull-build

Tooling for building various things related to ansible
GNU General Public License v3.0
60 stars 31 forks source link

Fix load_constraints_if_exists() filename parameter type #548

Closed felixfontein closed 8 months ago

felixfontein commented 1 year ago

Ref: https://github.com/ansible-community/antsibull/pull/546#discussion_r1338823182 Ref: https://github.com/ansible-community/antsibull/pull/546#discussion_r1338887145

gotmax23 commented 1 year ago

It'd be better to just change the type in the antsibull_core function. The os.fspath suggestion was more of a stopgap.

felixfontein commented 1 year ago

Good point. I started working on that in https://github.com/ansible-community/antsibull-core/pull/105.

felixfontein commented 8 months ago

Now that we updated antsibull-core, I've updated this PR :)

gotmax23 commented 8 months ago

Triggering CI

felixfontein commented 8 months ago

Thanks @gotmax23!