search

ansible-community / antsibull-build

Tooling for building various things related to ansible
GNU General Public License v3.0
60 stars 31 forks source link

add announcements subcommand to gen release announcement text #573

Closed gotmax23 closed 8 months ago

gotmax23 commented 9 months ago

@webknjaz, I amended the commits with your feedback and gave you a Co-authored-by:. Thanks!

gotmax23 commented 9 months ago

The lint session failures are fixed by https://github.com/ansible-community/antsibull/pull/574

gotmax23 commented 9 months ago

Rebased on top of main

gotmax23 commented 9 months ago

The lint session failures are fixed by #574

Well, the formatter ones were... There were still pylint issues.

gotmax23 commented 8 months ago

I'm marking this as ready for review. I think we can address the yarl transition separately.

webknjaz commented 8 months ago

Okay, fair. I don't see any obvious problems, otherwise, except for maybe --user that I remember bringing up elsewhere at some point. User-global installs are almost as harmful as the interpreter-global ones. But I suppose you didn't want to change the templates here, which is fine for now. Still, I'd link a PyPUG doc on installing apps for people to explore this.

felixfontein commented 8 months ago

@gotmax23 thanks a lot for implementing this! @webknjaz thanks a lot for reviewing!