search

ansible-community / antsibull-changelog

Changelog generator for ansible, ansible-base, and collections.
https://ansible.readthedocs.io/projects/antsibull-changelog/
GNU General Public License v3.0
36 stars 28 forks source link

Remove Python version check #167

Closed felixfontein closed 3 months ago

felixfontein commented 3 months ago

It was checking for Python 3.6, for which we dropped support quite some time ago (we're requiring Python 3.9+ since 2022-12-17).

samccann commented 3 months ago

Hmm. I can see the value of only maintaining the version in one location in source, but from a user perspective, if I just do a 'pip install antsibull-changelog' on a system with python 3.8 for example, it doesn't give me any errors. So if we remove the version check in this PR, how will I know it's not working (and why?).

felixfontein commented 3 months ago

@samccann you'll likely get an older version then that still works with Python 3.8 :) Only with extremely old pip versions that didn't check for the Python version would you get the latest version, but then the Python is probably also very old and it would complain about syntax errors before running any code :)

felixfontein commented 3 months ago

I rewrote the PR to remove the check.

felixfontein commented 3 months ago

@samccann @gotmax23 thanks a lot for reviewing this!