search

ansible-community / antsibull-core

Library for tooling for building various things related to ansible
https://pypi.org/project/antsibull-core/
GNU General Public License v3.0
6 stars 6 forks source link

Fix typing, use ClientTimeout instead of float, bump aiohttp dependency to 3.3.0+ #163

Closed felixfontein closed 2 months ago

felixfontein commented 3 months ago

I'm not sure whether there is an official deprecation, but the conversion code has been removed from master (https://github.com/aio-libs/aiohttp/pull/6328) and there's now (since 3.10.0) typing that makes mypy no longer accept floats. The code in 3.10.0 still accepts them though, so this isn't a runtime issue yet.

Also aiohttp 3.3.0+ is required for the timeout parameter that has been used by the GET retry manager since the beginning, so I updated the dependency version range.

Also pyre doesn't think ClientSession.get exists anymore with 3.10.0 :roll_eyes:

felixfontein commented 3 months ago

antsibull compatibility fails because of pyre...

felixfontein commented 2 months ago

Ping @gotmax23

patchback[bot] commented 2 months ago

Backport to stable-2: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 87e294e058f9edbf9d9cebfb0da6ede34b275e46 on top of patchback/backports/stable-2/87e294e058f9edbf9d9cebfb0da6ede34b275e46/pr-163

Backporting merged PR #163 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these instructions you'll refer to it by the name upstream. If you don't have it, here's how you can add it: 
    $ git remote add upstream https://github.com/ansible-community/antsibull-core.git
  3. Ensure you have the latest copy of upstream and prepare a branch that will hold the backported code: 
    $ git fetch upstream
$ git checkout -b patchback/backports/stable-2/87e294e058f9edbf9d9cebfb0da6ede34b275e46/pr-163 upstream/stable-2
  4. Now, cherry-pick PR #163 contents into that branch: 
    $ git cherry-pick -x 87e294e058f9edbf9d9cebfb0da6ede34b275e46

    If it'll yell at you with something like fatal: Commit 87e294e058f9edbf9d9cebfb0da6ede34b275e46 is a merge but no -m option was given., add -m 1 as follows instead:

    $ git cherry-pick -m1 -x 87e294e058f9edbf9d9cebfb0da6ede34b275e46
  5. At this point, you'll probably encounter some merge conflicts. You must resolve them in to preserve the patch from PR #163 as close to the original as possible.
  6. Push this branch to your fork on GitHub: 
    $ git push origin patchback/backports/stable-2/87e294e058f9edbf9d9cebfb0da6ede34b275e46/pr-163
  7. Create a PR, ensure that the CI is green. If it's not — update it so that the tests and any other checks pass. This is it! Now relax and wait for the maintainers to process your pull request when they have some cycles to do reviews. Don't worry — they'll tell you if any improvements are necessary when the time comes!

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

felixfontein commented 2 months ago

@gotmax23 thanks for reviewing this!

felixfontein commented 2 months ago

Backport to stable-2: #164.