Open gardar opened 6 months ago
Hey @gardar,
I just released antsichaut 0.3.8 on Pypi: https://github.com/ansible-community/antsichaut/releases/tag/0.3.8
I noticed that the last change to the changelog that happened prior to the indent getting screwed up was that version 0.10.0 got added to the changelog but it is missing the changes key.
If there are no changes detected, it should look like this:
releases:
0.10.1:
changes: {}
release_date: '2024-01-08'
This should be fixed by https://github.com/ansible-community/antsichaut/commit/3a29d647de882c39d3d3d41981251f53311f1972
It also looks like the sorting does not understand the semantic versioning fully as versions 0.10.0 and 0.10.1 are inserted between the last 0.1.x version and first 0.2.x version and not after version 0.9.x as you'd expect.
This too is fixed in 0.3.8, by PR https://github.com/ansible-community/antsichaut/pull/35/files
Can you test please with the latest release?
Excellent, first impressions of v0.3.8
are good, although I haven't tried running it without any changes.
From time to time this keeps happening, haven't been able to figure out exactly why or under what condition.
Here is a commit where my changelog.yaml got screwed up: https://github.com/prometheus-community/ansible/commit/a3aaf709a5b758cde0c51e9f5e3f972906ac266d#diff-badba4dd47cd1a24e2765eb5c5f420a529872e06a0ce09251c35ea2cb5b4ebd9
Curiously on the commit before that, the empty changes: {}
section was removed, which is perhaps the root cause of the changelog.yaml getting screwed up?
https://github.com/prometheus-community/ansible/commit/85d0ae83f186c1e712e07cce5063c4208f28be4b#diff-badba4dd47cd1a24e2765eb5c5f420a529872e06a0ce09251c35ea2cb5b4ebd9
Ran into a issue where
changelog.yaml
got screwed up somehow.I'm not sure what exactly caused it, but it seems like it's somehow related to when the collection got moved from a single-digit minor edition to a double-digit one (from version
0.9.0
to0.10.0
).I noticed that the last change to the changelog that happened prior to the indent getting screwed up was that version 0.10.0 got added to the changelog but it is missing the
changes
key.Looking through the history of the file I see that for other versions the
changes
key is always added when a new version is added to the changelog, such as:At the same time where the changelog.yaml indent got screwed up it also added a new section for version 0.10.1 which is missing the
changes
key.It also looks like the sorting does not understand the semantic versioning fully as versions
0.10.0
and0.10.1
are inserted between the last0.1.x
version and first0.2.x
version and not after version0.9.x
as you'd expect.I manually fixed the indent but since the
changes
key is missing for those versionsantsibull-changelog
fails to process the changelog.Here's the commit where the indent got screwed up: https://github.com/prometheus-community/ansible/commit/e0697b48c18928107ea5f4fe335a3e9a986e3223
Here's the commit where version 0.10.0 was added: https://github.com/prometheus-community/ansible/commit/2fb25ecc6340e4b87368fa987c98a5d6b2596c4b
The indenting issue has happened before: https://github.com/prometheus-community/ansible/commit/766f0d7ff559744e92e1a586b4f9fbb09421113e but it got fixed on the next run, however the broken version sections is not something I've seen before.