search

ansible-community / ara-collection

Collection of Ansible roles for ARA Records Ansible.
https://ara.recordsansible.org
GNU General Public License v3.0
28 stars 16 forks source link

Reworked ansible fact variables #27

Closed Thulium-Drake closed 3 years ago

Thulium-Drake commented 3 years ago

Reworked all ansible fact variables to be compatible with inject_facts_as_vars = false

This should fix #26 and make the roles future-proof.

dmsimard commented 3 years ago

The failure is in the postgresql job for fedora, we were missing python3-devel and the installation of psycopg from pip failed to compile: https://dashboard.zuul.ansible.com/t/ansible/build/82cc0e2472224478bc0e2f9422e6c91b

   ./psycopg/psycopg.h:35:10: fatal error: Python.h: No such file or directory
       35 | #include <Python.h>

I sent a PR to add python3-devel here: https://github.com/ansible-community/ara-collection/pull/28

Edit: the code otherwise looks great and the other jobs are happy. We should be able to merge it after rebasing on top of the python3-devel fix.

dmsimard commented 3 years ago

We can ask Zuul to check this PR again by sending a "recheck" comment -- I guess it would take care of the rebase during testing. Let's find out :)

dmsimard commented 3 years ago

recheck

dmsimard commented 3 years ago

It works now and I confirmed that the tests indeed ran with the ansible_facts variable change.

Thanks \o/