search

ansible-community / ara-collection

Collection of Ansible roles for ARA Records Ansible.
https://ara.recordsansible.org
GNU General Public License v3.0
28 stars 16 forks source link

Add support for managing authentication in ara_frontend_nginx #38

Closed dmsimard closed 3 years ago

dmsimard commented 3 years ago

This includes drive-by fixes but it's mostly about adding support for managing external authentication via a .htpasswd file in nginx as per the documentation: https://ara.readthedocs.io/en/latest/api-security.html#authentication-and-user-management

The PR also includes a new integration test which covers a large gap that we had in testing -- it will set up gunicorn with nginx in front managing the authentication.

Thulium-Drake commented 3 years ago

We're missing a python dependency for htpasswd:

ModuleNotFoundError: No module named 'passlib'

https://dashboard.zuul.ansible.com/t/ansible/build/06548ac0cdca467681c14a7e557704ed

dmsimard commented 3 years ago

We're missing a python dependency for htpasswd:

ModuleNotFoundError: No module named 'passlib'

https://dashboard.zuul.ansible.com/t/ansible/build/06548ac0cdca467681c14a7e557704ed

You're too fast :laughing:

I think https://github.com/ansible-community/ara-collection/pull/38/commits/f24ec00f27487e5050198c3f11b993ee62fb2cca should fix it.

dmsimard commented 3 years ago

:tada: IT WORKED \o/

I'll clean it up later and we can re-review before merging.

dmsimard commented 3 years ago

@Thulium-Drake would you like to do a last review ?

Cleaned up/squashed and rebased stuff and it should be good to go if Zuul is happy with it.