search

ansible-community / collection_bot

Fork of Ansibullbot for collections
GNU General Public License v3.0
5 stars 10 forks source link

[WIP] Bot based on upstream (take 2) #28

Closed dmsimard closed 2 years ago

dmsimard commented 2 years ago

Results of second dry-run after the latest WIP symlink commit: https://github.com/dmsimard/ansibullbot-test-actions/commit/1b5f1c2f8e3df6a2db3130cabd15c61e37817b33

dmsimard commented 2 years ago

I re-ran a full dry-run after fixing the symlink detection and manually reviewed all the actions in https://github.com/dmsimard/ansibullbot-test-actions/commit/29ca542f7d039dcd5ca87a587cc75061f211eb91

Three originally stood out:

With that in mind, I think this is good to go after someone else has reviewed.

dmsimard commented 2 years ago

I cherry-picked a26d660617db095069697426d8593c9d1fa4eed3 from the work that gundalow did in order to prevent the bot from closing patchback bot PRs.

dmsimard commented 2 years ago

We also found that the links to the plugin files was hardcoded as /devel/ and I've added https://github.com/ansible-community/collection_bot/pull/28/commits/db79cec732ca8b9c888b729c2e5d14db2e25179f which resolves the issue.

felixfontein commented 2 years ago

It looks like the bot currently insists that the "ansible-core version" is called "Ansible version", which is the wrong term (the Ansible version is 4.x.0, the ansible-core version 2.11.y). I yesterday made the mistake of correcting the field's name in c.g's issue template (ansible-collections/community.general#3458) and that resulted in the bot not being happy (https://github.com/ansible-collections/community.general/issues/3466#issuecomment-929628525). I think we need to adjust the bot so it accepts "ansible-core version" as well, and not just "ansible version".

dmsimard commented 2 years ago

I've rebased the PR as well the (our) upstream branch and we've been running with it long enough that we can merge it and address other potential improvements in another PR.

@felixfontein, I'll spin out your comment into an issue.