search

ansible-community / collection_bot

Fork of Ansibullbot for collections
GNU General Public License v3.0
5 stars 10 forks source link

Ansibullbot does not understand zuul CI status #8

Open jillr opened 3 years ago

jillr commented 3 years ago

For collections that use the bot for triage, but zuul for CI and gating/merging the bot doesn't currently understand the Zuul CI checks. In ansible/ansible some checks were still performed via shippable andthe Zuul tests were a ansible/third-party-check. In collections these repos, such as for community.vmware, are executed entire on Zuul.

This results in a needs_ci label being applied that reviewers need to just ignore, which is confusing. Example: https://github.com/ansible-collections/vmware/pull/318

gundalow commented 3 years ago

If we go down the route of config file per repo then we could add a ci flag, and only do needs_ci and stale_ci if set to shippable

gundalow commented 3 years ago

@mkrizek Has this been fixed in the main bot repo?

mkrizek commented 3 years ago

@gundalow this is intended behavior for ansible/ansibullbot, the ansibot specifically looks for Shippable results and ignores the rest so I suspect if a PR in ansible/ansible would have zuul results and no shippable results then the bot would apply needs_ci.

My recent effort to create an abstraction to allow for different CI providers would allow for Zuul CI to be the CI that the bot would look at. However that work is still WIP.