search

ansible-community / collection_migration

DONE AND DONE: Was scripts and scenarios for migration from core code to collections
19 stars 26 forks source link

No need for empty __init__.py in plugin dirs #452

Closed mkrizek closed 4 years ago

mkrizek commented 4 years ago

Fixes #450

bcoca commented 4 years ago

holding off on this, till we verify the scope and if this actually creates issues on collections (other than extra files).

webknjaz commented 4 years ago

I checked that it was there since the initial commit. So it's not related to what I recall. I confused it with https://github.com/ansible-community/collection_migration/issues/80. It should be fine to merge this one.

nitzmahone commented 4 years ago

Yep, it's unnecessary for collections to function since AnsibleCollectionLoader implements its own implicit namespace packages (that also work on Python 2.7). The only reason you'd need those is for poking at collections with native Python 2.7 tools that aren't using our loader, which should be decreasingly likely over time.

bcoca commented 4 years ago

since this does not 'hurt' and does enable common python tools to keep working, going to close and let 'collection maintainers' decide to purge them at later date.