Closed oraNod closed 10 months ago
One comment on accessibility here. I was able to navigate the mailchimp form by keyboard and all fields are labeled. Here is the WAVE report: https://wave.webaim.org/report#/https://ansible.us19.list-manage.com/subscribe?u=56d874e027110e35dea0e03c1&id=d6635f5420
There are some higher level page errors but the form itself doesn't have any specific accessibility violations. This seems to indicate to me that users with assistive technology would be able to access the subscribe form and use it as intended.
Looks good! I'm not too sure about using the mailchimp icon on the button though. I feel like it's hard to see and the button is descriptive enough to indicate the action.
Looks good! I'm not too sure about using the mailchimp icon on the button though. I feel like it's hard to see and the button is descriptive enough to indicate the action.
@tiyiprh Yeah, good call. It's better without that icon.
Resolves issue #351
This PR:
Mobile: