search

ansible-community / community-website

Ansible Community website (WIP)
https://ansible-community-website.readthedocs.io
Creative Commons Attribution Share Alike 4.0 International
14 stars 25 forks source link

fix subscribe bull #443

Closed oraNod closed 6 months ago

oraNod commented 6 months ago

Resolves #382

tiyiprh commented 6 months ago

This looks a lot better to me! Sorry for the nitpick but would it be possible to make that section a bit shorter by removing some padding from the top and bottom of the section? It should be about the same height as the bull. Here is an example from the mockup.

Screenshot 2024-03-05 at 9 23 42 AM
oraNod commented 6 months ago

@tiyiprh Please take another look. Use responsive design mode in the browser to look at different sizes etc. If we want to reduce the padding on the top and bottom we'll need to add a new global style. I'm not too convinced it's worth doing that though because it deviates from the other bands. Also it's really tricky to get the same amount of padding at the various sizes.

tiyiprh commented 6 months ago

@oraNod I think I see what you mean about the padding when it reduces in size. I'm ok with what you had earlier if that helps avoid adding a new global style and keep it consistent across the various sizes.

oraNod commented 6 months ago

Thanks @tiyiprh I think it's better to try and keep it consistent here. I agree that the mockup looks nicer but it gets complicated once you start resizing and all that. I've dropped that last commit if you could look again. Cheers.