build-html - ensure artifact root matches build html root

ansible-community / github-docs-build

GitHub actions and workflows for building Ansible collection documentation.

GNU General Public License v3.0

10 stars 6 forks source link

build-html - ensure artifact root matches build html root #25

Closed briantist closed 2 years ago

briantist commented 2 years ago

Fixes: #24

fix typos in workflow triggers that prevented tests running
add trailing slash to rsync command for copy-build option
add tests to ensure artifact does not contain additional directory
add tests that add a trailing slash on inputs to ensure it adding it again to rsync doesn't break

briantist commented 2 years ago

Adding a test for this without a fix has revealed that the problem occurs only with the action's copy-build option; it looks like the place where I needed to add the trailing slash is really within the rsync. Need to put this down for the moment, so marking as draft, will get back to this tomorrow.

felixfontein commented 2 years ago

rsync is best used always with trailing slashes :)

briantist commented 2 years ago

thanks for reviewing @felixfontein !