search

ansible-community / github-docs-build

GitHub actions and workflows for building Ansible collection documentation.
GNU General Public License v3.0
10 stars 6 forks source link

Replace set-output by GITHUB_OUTPUT #57

Closed felixfontein closed 1 year ago

felixfontein commented 1 year ago

Fixes #56.

briantist commented 1 year ago

looks great so far, but looking at the annotations, may have missed some:

felixfontein commented 1 year ago

There's none more in this repository (I've grepped for it). Maybe some of these tests use actions from the main branch?

briantist commented 1 year ago

There's none more in this repository (I've grepped for it). Maybe some of these tests use actions from the main branch?

Ok so it turns out these are from other actions we're using. We should update setup-python to use v4: the breaking change in that version is that it no longer has a default python version so if we're not already, we'll need to specify one (no big deal). Would you mind updating that in this PR?

The other thing causing the warnings is download-artifact, which unfortunately doesn't have a fix yet, so we'll just have to wait for it and update it later if it ends up being a new major version:

briantist commented 1 year ago

thanks @felixfontein !