search

ansible-community / github-docs-build

GitHub actions and workflows for building Ansible collection documentation.
GNU General Public License v3.0
10 stars 6 forks source link

Bump peaceiris/actions-gh-pages action. #89

Closed felixfontein closed 5 months ago

felixfontein commented 7 months ago

This includes the latest commit, https://github.com/peaceiris/actions-gh-pages/commit/4eb285e828117bca26638192c3ed309c622e7bad, which removes the annoying warning.

Changes: https://github.com/peaceiris/actions-gh-pages/compare/373f7f263a76c20808c831209c920827a82a2847..4eb285e828117bca26638192c3ed309c622e7bad

Unfortunately there is no new release yet, so I've used the commit hash of the latest commit (which happens to be the commit bumping Node).

I have not updated the version comment in the hope that Dependabot will do this soon when a new version is out (which I hope will be soon, no idea whether that will actually happen). I'm not sure whether this is a good idea, since now the comment is definitely incorrect. @briantist WDYT?

briantist commented 7 months ago

I think we could probably give it some time for the release to happen, no? The change was merged only 15 hours ago. If the warning is very annoying I'm ok with merging this though I haven't noticed it myself.

felixfontein commented 7 months ago

Let's hope they release a new version soon...

felixfontein commented 5 months ago

https://github.com/peaceiris/actions-gh-pages/issues/1070 has been sitting around for over a month now.

felixfontein commented 5 months ago

Let's hope we can replace it by a proper new version soon...

felixfontein commented 5 months ago

Hmm, I reverted this PR (13b666656d4dfee5fcfaf09b3d86d0bf6bf05b34) since it causes failures: https://github.com/ansible-collections/community.docker/actions/runs/8590192028/job/23537411686?pr=832

briantist commented 5 months ago

ah that's a shame.. thank you for taking care of that @felixfontein

felixfontein commented 5 months ago

There's a new release, I've created #90 to update.