ansible-community / molecule-plugins

Collection on molecule plugins
MIT License
101 stars 67 forks source link

Disable registry login when registry.url is empty #214

Closed dometto closed 7 months ago

dometto commented 7 months ago

Resolves #213

See #213 for context. This implements the suggestion I provide there.

Let me know if you believe this (or e.g. the alternative I propose in the issue) is desirable, or whether the solution can be improved! Also let me know if I need to provide any kinds of tests for this, but I don't really notice them in the repo.

Many thanks for considering this, and for working on this project!

dometto commented 7 months ago

Thanks for the review @zhan9san! I've committed your suggestion and also implemented the same logic for the podman playbook.