ansible-community / molecule-plugins

Collection on molecule plugins
MIT License
109 stars 73 forks source link

OpenStack - Improve connection check after instance creation #231

Open mathias-ioki opened 8 months ago

mathias-ioki commented 8 months ago

The Wait for SSH task in the create.yml playbook makes some assumptions:

Both of them are not always true, especially the first one. Especially in cloud environments a bastion node / jumphost is used very often to connect to the VMs. Such a scenario can't be used with the current implementation.

Therefore I would suggest to move this task to the prepare.yml playbook. We can use wait_for_connection then, which respects the ssh config (jumphost, ports, ...) and the ansible config for these hosts. So both described use cases are now possible.

This can break existing configurations, if the prepare.yml is overridden within the actual molecule test.

github-actions[bot] commented 8 months ago

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found: