search

ansible-community / molecule-plugins

Collection on molecule plugins
MIT License
101 stars 67 forks source link

Update the `community.docker` collection #257

Open mcdonnnj opened 1 month ago

mcdonnnj commented 1 month ago

Includes fixes related to https://github.com/psf/requests/issues/6707 and https://github.com/docker/docker-py/issues/3256

Fixes #256.

mcdonnnj commented 1 month ago

The test failures appear to be a result of the version of ansible-core installed (2.17.0). This latest version of ansible-core has dropped support for module execution by Python 3.6, but the Docker image used for testing (docker.io/pycontribs/centos:8) has Python 3.6.8. I am not sure what image the maintainers would like to move to as there is no newer version of the docker.io/pycontribs/centos image available. The images that are available haven't been updated in three years which matches the repository.

jsf9k commented 1 month ago

What can I do to help move this PR forward? I really need this fix.

DChalcraft commented 1 month ago

👍 for this

konstruktoid commented 1 month ago

The test failures appear to be a result of the version of ansible-core installed (2.17.0). This latest version of ansible-core has dropped support for module execution by Python 3.6, but the Docker image used for testing (docker.io/pycontribs/centos:8) has Python 3.6.8. I am not sure what image the maintainers would like to move to as there is no newer version of the docker.io/pycontribs/centos image available. The images that are available haven't been updated in three years which matches the repository.

The hub images are available at https://hub.docker.com/r/pycontribs/centos/tags and I'm in the progress to write a PR to align CentOS with the rest of the images (using :latest and such).

sebdanielsson commented 1 month ago

Testing against CentOS doesn't really make sense since it has reached EOL? CentOS Stream 9 or AlmaLinux would make more sense, right?

konstruktoid commented 1 month ago

yeah, my PR will use AlmaLinux

konstruktoid commented 1 month ago

PR submitted

jrgoldfinemiddleton commented 1 month ago

You are a soldier!

mcdonnnj commented 2 weeks ago

@ssbarnea I do not believe tests will not pass for this PR until https://github.com/ansible-community/molecule-plugins/pull/257#issuecomment-2128606576 is resolved. I'm happy to make any changes you'd like to move this PR forward.