ansible-community / molecule-plugins

Collection on molecule plugins
MIT License
109 stars 73 forks source link

💖 vagrant plugin welcomes new contributors and maintainers #63

Closed ssbarnea closed 10 months ago

ssbarnea commented 4 years ago

I am unable to maintain this driver as I am not using it, so I am looking for maintainers.

I can keep providing support for integration with molecule itself but not around vagrant bits.

I would work noting that the top priority would be to setup CI jobs.

hswong3i commented 4 years ago

@ssbarnea could i give a hand for this driver?

I am now using it for all of my Ansible roles, in Travis CI + Libvirt + KVM, see:

jonashackt commented 4 years ago

I also would say CI jobs would be a show stopper for anyone trying to help with this (I also think about helping out...). I was already loosely involved in https://github.com/ansible-community/molecule/pull/1600#issuecomment-445828834 and tried to create an example pipeline using a free CI platform to be able to create VagrantBoxes (with VirtualBox) in https://github.com/jonashackt/vagrant-ansible-on-appveyor - but sadly failed back then.

Now with the Molecule v3 release I stepped back into the game, since there was some development at AppVeyor since then and there seems to be a possiblity right now, to use Vagrant with them. Therefor I filed an issue https://help.appveyor.com/discussions/questions/46774-nested-virtualization-needed-for-opensource-projects-vt-x-is-not-available-verr_vmx_no_vmx - let's see, if they will help here. Will come back, if there's any progress. I don't really see other free options aside from AppVeyor, everything else needs to be payed for...

jonashackt commented 4 years ago

Ah @hswong3i I misread your solution, sounds great. Will look into it.

jonashackt commented 4 years ago

Wow @hswong3i this really works... Vagrant + libvrt Plugin + libvrt + KVM on Travis... nice - full example here https://github.com/jonashackt/vagrant-travisci-libvrt. So this could be also a way of creating the CI jobs for Molecule 👍

sio commented 4 years ago

@jonashackt, CirrusCI also offers free virtualization: https://cirrus-ci.org/guide/linux/#kvm-enabled-privileged-containers

I'm testing my Ansible roles there.

ssbarnea commented 4 years ago

I welcome anyone to join this. You will need to document for each CI how to setup Vagrant and assure that it is working. Installing vagrant does not mean it will be able to start a VM.

I am currently working on fixing this for Zuul CI, which is what we use for testing.

ssbarnea commented 4 years ago

CI is working, feel free to start creating PR now, or reviewing existing ones.

Be sure you use the review option when doing reviews, when approved we should see a gray "v" check. Mentioning because the review option is well hidden in the UI.

hswong3i commented 4 years ago

@ssbarnea thank you very much and confirmed after ansible-community/molecule-vagrant#10 get committed with https://github.com/ansible-community/molecule-vagrant/commit/78582f9f7ead498575f0acc12ace7b9e187306ad, no more hacky dirty workaround is required for:

My complete example for migrate from Molecule 2.22.0 to 3.0.2 goes here:

Enjoy ;-)

stdevel commented 4 years ago

Thank you so much, @hswong3i - I'm finally able to use Molecule with Vagrant again! 🎉

hswong3i commented 4 years ago

@ssbarnea thank you very much for v0.2, example above updated, too ;-)

hswong3i commented 4 years ago

@jonashackt For Travis CI + Vagrant + VirtualBox we may need --nested-hw-virt, which natively enabled for Libvirt + KVM

See https://www.virtualbox.org/manual/ch09.html#nested-virt

apatard commented 4 years ago

I've said it on IRC but it's a good idea to say it here too. If help is still needed/wanted, I can try helping in maintaining the vagrant molecule plugin.

ssbarnea commented 4 years ago

Please watch the project and do reviews on issues or PRs. Even ping me directly here or on irc, after this I will also give you more privileges.

It would also be very useful if you can find a way to fix the vagrant installation on the broken platforms (so we can remove the voting: false)

rgarrigue commented 4 years ago

Thanks @hswong3i for the example. Wish this could be added in the doc.

ssbarnea commented 4 years ago

I invited few people but I will keep the ticket open. If you want to help, just add a comment here and mention my name. I will send you an invite so you can start doing triage, reviews.

karcaw commented 4 years ago

this code is becoming very important to our team and will be for years I believe, so I'll add my name to the list of people that can help

ssbarnea commented 4 years ago

Done, invited all. If I missed anyone mention me in a comment.

Please watch the project for PRs and review them, only when it gets reviews add the "gate" label to tell CI to merge it. There is not manual merge.

bbaassssiiee commented 4 years ago

@kikitux is this something for you? @ssbarnea