molecule-podman does not honor pull parameter

ansible-community / molecule-plugins

Collection on molecule plugins

MIT License

109 stars 73 forks source link

molecule-podman does not honor pull parameter #76

Closed wouterhummelink closed 10 months ago

wouterhummelink commented 3 years ago

On the docker driver it's supported to specify if the base image should be pulled or not. The podman driver does not, causing image updates in our pipeline not to occur.

javierpena commented 3 years ago

I think this could be fixed by adding a line like the following in the block at https://github.com/ansible-community/molecule-podman/blob/master/lib/molecule_podman/playbooks/create.yml#L89-L109 :

{% if item.pull is defined and item.pull %}--pull always{% elif item.pull is defined and not item.pull %}--pull never{% endif %}

@ssbarnea what do you think?

ssbarnea commented 3 years ago

Probably, make a PR. Sadly I am overloaded now so I cannot dig myself it but I can review a patch and tag a release if needed.