ansible-lockdown / AMAZON2023-CIS

Ansible role for Amazon2023 CIS Baseline
https://ansible-lockdown.readthedocs.io/en/latest/
MIT License
24 stars 18 forks source link

A prelim task is not used anywhere #50

Closed DianaMariaDDM closed 5 months ago

DianaMariaDDM commented 6 months ago

Describe the Issue The "PRELIM | Install authconfig" task is not used anywhere.

Expected Behavior All tasks that exist should serve a purpose for the role.

Actual Behavior The task "PRELIM | Install authconfig" is not used anywhere. First, I noticed the tags and when conditional, contained rule numbers that do not exist such as: rule_5.3.1, rule_5.3.2, rule_5.3.3. Then while searching I realised authconfig is not needed anywhere for the role to fulfil its purpose.

Control(s) Affected None, the task always gets skipped anyway.

Environment (please complete the following information):

Additional Notes Anything additional goes here

Possible Solution I will provide a PR that removes this task, as a solution!

DianaMariaDDM commented 6 months ago

Hello, I come back with one other small mention regarding this.

The role does indeed not use authconfig but it uses authselect. If authselect is not installed some rules may fail because of that.

I propose that we should add a preliminary task that installs authselect.

I will create a PR based on this issue.