Closed LeroyZwakman closed 2 years ago
hi @LeroyZwakman
Thank you for this PR, feedback like this helps us to improve for everyone.
As you maybe able to see your merge is currently failing a DCO check before we run the workflow. This is checking for the sign off which is currently showing as missing. We are happy to add this into the next update we do if you would like to leave it. Alternatively if you want to sign it off we can pull to an alternative branch while we migrate to a new workflow and then merge to devel later?
Many thanks once again for taking the time to contribute.
uk-bolly
Hi @uk-bolly,
Thank you for your comment, i thought this wouldn't be blocking. I've ran the commands stated for the signoff.
Do i need to create a new PR, or will the check run again?
grtz Leroy
edit: seeing a green checkmark :)
Hi @LeroyZwakman
Thank you for turning that around so quickly. Due to issues we currently have with the pipeline, i am pulling into a local staging in the first instance and then able to pull into devel.
Thank you once again for you feedback and hopefully this will be in devel tomorrow.
Regards uk-bolly
Hi @uk-bolly,
Thanks for your help, probably there are more PR's coming due to our extra hardening..:)
Grtz Leroy
follow is removed from module replace inn Ansible 2.5
Overall Review of Changes: removed the follow parameter
Issue Fixes:
Enhancements: none
How has this been tested?: If follow directive is not removed; Ansible throws an error:
After removing the follow parameter; playbook runs this task just fine.