ansible-lockdown / RHEL7-CIS

Ansible role for Red Hat 7 CIS Baseline
https://ansible-lockdown.readthedocs.io/en/latest/
MIT License
473 stars 303 forks source link

Update cis_3.1.x.yml #261

Closed LeroyZwakman closed 2 years ago

LeroyZwakman commented 2 years ago

follow is removed from module replace inn Ansible 2.5

Overall Review of Changes: removed the follow parameter

Issue Fixes:

Enhancements: none

How has this been tested?: If follow directive is not removed; Ansible throws an error:

TASK [ans_al_role_rhel7_cis : 3.1.1 | L2 | PATCH | Disable IPv6 | grub] ****************************************************************
fatal: [fnalg-pv-smtp02.finance.cloud]: FAILED! => changed=false
  msg: 'Unsupported parameters for (replace) module: follow. Supported parameters include: path (dest, destfile, name), seuser, group, encoding, unsafe_writes, selevel, after, setype, replace, serole, mode, owner, regexp, validate, backup, attributes (attr), before.'

After removing the follow parameter; playbook runs this task just fine.

uk-bolly commented 2 years ago

hi @LeroyZwakman

Thank you for this PR, feedback like this helps us to improve for everyone.

As you maybe able to see your merge is currently failing a DCO check before we run the workflow. This is checking for the sign off which is currently showing as missing. We are happy to add this into the next update we do if you would like to leave it. Alternatively if you want to sign it off we can pull to an alternative branch while we migrate to a new workflow and then merge to devel later?

Many thanks once again for taking the time to contribute.

uk-bolly

LeroyZwakman commented 2 years ago

Hi @uk-bolly,

Thank you for your comment, i thought this wouldn't be blocking. I've ran the commands stated for the signoff.

Do i need to create a new PR, or will the check run again?

grtz Leroy

edit: seeing a green checkmark :)

uk-bolly commented 2 years ago

Hi @LeroyZwakman

Thank you for turning that around so quickly. Due to issues we currently have with the pipeline, i am pulling into a local staging in the first instance and then able to pull into devel.

Thank you once again for you feedback and hopefully this will be in devel tomorrow.

Regards uk-bolly

LeroyZwakman commented 2 years ago

Hi @uk-bolly,

Thanks for your help, probably there are more PR's coming due to our extra hardening..:)

Grtz Leroy