search

ansible-lockdown / RHEL7-CIS

Ansible role for Red Hat 7 CIS Baseline
https://ansible-lockdown.readthedocs.io/en/latest/
MIT License
473 stars 303 forks source link

Various fixes #1 - dmaraidonis #267

Closed dmaraidonis closed 2 years ago

dmaraidonis commented 2 years ago

Various changes based on execution on local RHEL7 nodes

georgenalen commented 2 years ago

@dmaraidonis. Thanks for creating this PR to address some issues. One thing that will need to be updated before we can merge it in is your DCO needs some updating. You will need to update your commits to have both a GPG signed and a signed-off by. Once those two things are done you will see the DCO portion of the PR passing. Let me know if you need some help figuring that out. Also if it becomes a huge pain I can convert this to an issue and then make the changes on my side.

George

dmaraidonis commented 2 years ago

Hi George,

Please convert this to an issue and make the changes on your side. Also please delete this commit and a 'revert' commit that I added today by mistake.

Thanks, Dimtiris

On Tue, 23 Nov 2021 at 15:25, George Nalen @.***> wrote:

@dmaraidonis https://github.com/dmaraidonis. Thanks for creating this PR to address some issues. One thing that will need to be updated before we can merge it in is your DCO needs some updating. You will need to update your commits to have both a GPG signed and a signed-off by. Once those two things are done you will see the DCO portion of the PR passing. Let me know if you need some help figuring that out. Also if it becomes a huge pain I can convert this to an issue and then make the changes on my side.

George

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ansible-lockdown/RHEL7-CIS/pull/267#issuecomment-976530175, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAW3L6N7X2XAIA2NHZUJUPDUNOI5XANCNFSM5IRKZ46A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

dmaraidonis commented 2 years ago

Hi George,

The commit is now signed off.

Thanks, Dimitris

dmaraidonis commented 2 years ago

Hi @georgenalen

I added another commit to this PR. Can you please review?

Best regards, Dimitris

dmaraidonis commented 2 years ago

Please ignore and delete this pull request