search

ansible-lockdown / RHEL7-CIS

Ansible role for Red Hat 7 CIS Baseline
https://ansible-lockdown.readthedocs.io/en/latest/
MIT License
473 stars 303 forks source link

Section 1.4 included on wrong variable? #303

Closed ikeusmaximus closed 1 year ago

ikeusmaximus commented 2 years ago

This might be said in ignorance (if so apologies and close issue), but what do bootloader settings have anything to do with AIDE specifically, let alone the installation of a package and the presence of a cron job? I think section 1.4 needs to be included on it's own variable? And/or maybe section 1.3 needs to be updated? RHEL8-CIS I think has this right.

https://github.com/ansible-lockdown/RHEL7-CIS/blob/90f3d9a5fecebb75e16afe32ba096bf7817cd034/tasks/section_1/main.yml#L15

uk-bolly commented 2 years ago

hi @ikeusmaximus

Thats a great catch it should be on 1.5. I have movedt hat in the latest PR and will get that followed up asap.

Thank you for your time and raising this issue.

regards

uk-bolly

ikeusmaximus commented 2 years ago

Do you mean 1.3?

uk-bolly commented 2 years ago

I did indeed. PR raised and should be resolved shortly.

Thank you again for your feedback.

uk-bolly commented 2 years ago

HI @ikeusmaximus

Thank you again fro raising this, feedback like this really helps to improve. This has now been merged to devel. There is also another PR open that has a number of improvements contained.

Regards

uk-bolly

uk-bolly commented 1 year ago

Hi @ikeusmaximus

This Issue has now been merged are you happy to close this?

Thanks uk-bolly