search

ansible-lockdown / RHEL7-CIS

Ansible role for Red Hat 7 CIS Baseline
https://ansible-lockdown.readthedocs.io/en/latest/
MIT License
472 stars 303 forks source link

Ansible core 2.12+ can't manage /etc/crontab #305

Closed davidolrik closed 1 year ago

davidolrik commented 1 year ago

This is the same issue as in https://github.com/ansible-lockdown/RHEL8-CIS/issues/160

As stated in the docs:

If specified, uses this file instead of an individual user’s crontab. The assumption is that this file is exclusively managed by the module, do not use if the file contains multiple entries, NEVER use for /etc/crontab.

This PR changes the cron file to /etc/cron.d/cis_aide.

uk-bolly commented 1 year ago

Hi @davidolrik

Thank you for picking up on this issue and finding documenting the solution. We have been working through the open issues this morning and noticed that the PR you have submitted is not signed (I will fix the pipeline error). I have therefore added this into the new PR and credits will be given.

Many thanks once again

uk-bolly

davidolrik commented 1 year ago

For future reference, how do I sign a PR? (My commit was signed)

uk-bolly commented 1 year ago

Hi @davidolrik

We do required that the signed-off-by and the gpg signing is added to each commit. This can be seen by clicking on the short hash for each commit shown in this PR. it appears yours is missing the signed-off-by: This can be added into your gitconfig file.

e.g.

[user]
    signingkey = redacted
    name = redacted
    email = redacted
[commit]
    gpgsign = true
[trailer "sign"]
    key = "Signed-off-by: "
    ifmissing = add
    ifexists = doNothing
    command = echo \"$(git config user.name) <$(git config user.email)>\"

Ensuring that your email listed matches the one associated with your github account.

Hoping that helps.

uk-bolly