search

ansible-lockdown / RHEL8-CIS-Audit

Audit configurations for RHEL8 CIS - utilising goss
MIT License
31 stars 25 forks source link

Regarding certain errors found when running full audit run #41

Closed Kedy1ykh closed 1 year ago

Kedy1ykh commented 2 years ago

Hi dev team,

I have noticed some of the missing rules in json report and did a backtrack to try to analyse the reason behind the missing rules. Some of the missing rules were cause by errors generated from goss validation.

Attached some of my findings and hope to hear more from you.

cis_2.3.1_6.yml.txt Actinum_RHEL8_CIS_AUDIT_git_diff.txt Actinum_RHEL8_CIS_AUDIT_git_status.txt

uk-bolly commented 2 years ago

Hi @Kedy1ykh

There is some great catches there and some brilliant work, thank you very much for the details. Did you want to open a pull request to merge into devel for your local branch and we can test and adopt these as soon as possible. Please note. These do need to be gpg signed and signed-off That way you receive the credit for all your work by merging into the repo. Or i can look to adopt these and mark as credit in the new PR?

best regards and thank you again

uk-bolly

Kedy1ykh commented 2 years ago

Hi https://github.com/uk-bolly

Thanks for the response, i will try to merge it to devel branch today.

uk-bolly commented 1 year ago

This has now been merged.