ansible-lockdown / RHEL8-CIS-Audit

Audit configurations for RHEL8 CIS - utilising goss
MIT License
31 stars 24 forks source link

Formatting and small fixes #47

Closed cf-sewe closed 10 months ago

cf-sewe commented 10 months ago

Pull request details

Overall Review of Changes:

Issue Fixes:

n/a

Enhancements:

n/a

How has this been tested?:

run_audit.sh successfully executed.

uk-bolly commented 10 months ago

Hi @cf-sewe

Thank you so much for the excellent work, time and effort in this PR. I was actually this week addressing an update for the run_audit script due to changes in goss (new release we are rewriting some repos to use), I have adopted your linting into this and credits are no in the script (thank you again). I will make RHEL8-CIS-Audit first to get this new script version, I raise the PR for the script to be updated and ensure merged before I look at this PR in depth so i can check across the board. This will mean a new pull from you before i am able to merge this. I have however noted that there are DCO issues, either the signed-off by of missing, the commits are not gpg signed or the gpg sign does not match the email address for the key. I will add the contributing.md to the repo also (thanks for highlighting this). If you can resolve the DCO issues once i have merged, i am sure at a quick look that i will be adopting this great work.

many thanks once again

uk-bolly

cf-sewe commented 10 months ago

Hello Bolly,

thank you for your continued support in these hardening projects! And its just fair if I can add some improvements too. Once youre done with the changes, I will update this PR (or create a new one , whatever you prefer), also with signed-off commits :)

cf-sewe commented 10 months ago

I will create a new PR with these and a few more changes