ansible-lockdown / RHEL8-CIS-Audit

Audit configurations for RHEL8 CIS - utilising goss

MIT License

31 stars 24 forks source link

Fix several audit issues #48

Closed cf-sewe closed 10 months ago

cf-sewe commented 10 months ago

Pull request details

Overall Review of Changes:

Mostly, fixed some false alarms.

Issue Fixes: n/a

Enhancements: n/a

How has this been tested?: Executed run_audit.sh and checked the results.

uk-bolly commented 10 months ago

hi @cf-sewe

Superb work, as mentioned the new run_audit script is now merged, so i am hoping all is good to go once you pull that in. I will test further tomorrow. Brilliant effort

thanks

uk-bolly

cf-sewe commented 10 months ago

Thank you for your prompt response and warm words! Merge from remote:devel is done now.

(I decided not to merge the spacing/formatting changes for now and focus on functional topics first)

cf-sewe commented 10 months ago

FYI I tested with latest goss version 0.4.x and it generally works. Some deprecation warnings but nothing functional I would say.

uk-bolly commented 10 months ago

FYI I tested with latest goss version 0.4.x and it generally works. Some deprecation warnings but nothing functional I would say.

Thats the next thing i'm working on around audit, when not on client work. 0.4 has some great changes and gets around a few limitations ive hit so i'm rewriting to utilise that more, hence the check on goss version now in the script :). If i can get a yamllint working with this format that would help so much with the lint.

Thanks again

uk-bolly