ansible-lockdown / RHEL8-CIS-Audit

Audit configurations for RHEL8 CIS - utilising goss
MIT License
31 stars 24 forks source link

bug in use audit with goss >0.4.x #53

Open sysop200 opened 9 months ago

sysop200 commented 9 months ago

There are plans to rework the audit to work with goss version >0.4.x When using version >0.4.x, the field does not contain the correct queries: "matcher-result": {

"Actual": "object: *bytes.Reader",

"Expected": [ "/^MaxAuthTries [1-4]/", "!/^MaxAuthTries [5-9]/" ], "ExtraElements": null, "Message": "to have patterns", "MissingElements": [ "/^MaxAuthTries [1-4]/"

created an issue in the developer's repository https://github.com/goss-org/goss/issues/845

uk-bolly commented 9 months ago

hi @sysop200

Thank you for raising this issue. We are currently working on other repositories. We are aware of the 0.4 change. We have already rewritten one audit to allow this to work. I will test and look at this further and discuss with goss owner to go through with them.

Many thanks

uk-bolly

sysop200 commented 9 months ago

Hi, I am very glad that this is not only my problem and you are also interested in it. I will wait for this decision. Best regards!

sysop200 commented 7 months ago

Hmm... With the new version of goss this test does not work at all. it's a pity. We need to review all the tests again. audit_sysop.4check.ru_1700413601.json

uk-bolly commented 7 months ago

I'm working my way through the audits. The priority currently is client requirements. Hopefully not much longer we can get this done.

Thanks

uk-bolly

On Sun, 19 Nov 2023, 17:11 Michael Nekhoroshev, @.***> wrote:

Hmm... With the new version of goss this test does not work at all. it's a pity. We need to review all the tests again. audit_sysop.4check.ru_1700413601.json https://github.com/ansible-lockdown/RHEL8-CIS-Audit/files/13403926/audit_sysop.4check.ru_1700413601.json

— Reply to this email directly, view it on GitHub https://github.com/ansible-lockdown/RHEL8-CIS-Audit/issues/53#issuecomment-1817919498, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQQCCXLEQJFSFOGNQBRQAWTYFI4THAVCNFSM6AAAAAA5T4HDQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXHEYTSNBZHA . You are receiving this because you were assigned.Message ID: @.***>

sysop200 commented 7 months ago

I do not insist. Thank you so much for the inspiration with your set of scripts. Very necessary in the work of a security officer

uk-bolly commented 2 months ago

hi @sysop200

Apologies it has taken so long to get back to you. There was a new release of CIS shortly after our discussion, there is a new benchmark v3.0, which required an almost complete rewrite of both this audit and the remediate this is compatible with the 0.4x version of the goss binary.

Kindest regards

uk-bolly

sysop200 commented 2 months ago

Thanks a lot! I had to edit the configurations myself. But I’ll take your version and compare it with mine again, maybe I missed any mistakes on my part. There is a very lack of language support. I'm working on it now.

uk-bolly commented 3 weeks ago

hi @sysop200

Ive seen the discussions on the goss repo. We happy to close this issue off, while the source is fixed?

many thanks

uk-bolly